[FFmpeg-devel] [PATCH 3/3] swscale/output: Fix several invalid shifts in yuv2rgb_full_1_c_template()

[Andreas Rheinhardt]

On Tue, Jan 21, 2020 at 11:24 PM Michael Niedermayer <michael at niedermayer.cc>
wrote:

> Fixes: Invalid shifts
> Fixes: #8320
>
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libswscale/output.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libswscale/output.c b/libswscale/output.c
> index d192ea854b..439de04a05 100644
> --- a/libswscale/output.c
> +++ b/libswscale/output.c
> @@ -2111,8 +2111,8 @@ yuv2rgb_full_1_c_template(SwsContext *c, const
> int16_t *buf0,
>          int A = 0; //init to silence warning
>          for (i = 0; i < dstW; i++) {
>              int Y = buf0[i] << 2;
>

buf0[i] is an int16_t. Is it certain (in the sense of: checked, not in the
sense of "negative luminance is nonsense") that it can't be negative?
LGTM apart from that.

- Andreas