[FFmpeg-devel] [PATCH 3/4] avfilter/asrc_sine: Fix invalid left shift of negative number

[Nicolas George]

Nicolas George (12020-01-22):
> Andreas Rheinhardt (12020-01-22):
> > Clang with UBSan. It of course works in practice, but we don't know whether
> > future compilers might exploit undefined behaviour in an unintended way, so
> > these theoretical issues should be fixed.
> 
> This one is rather clear-cut. Although I would very much appreciate an
> excerpt of the code before and after.
> 
> But for the future, we must remember that the difference between
> undefined behavior and implementation defined behavior is only relevant
> to compiler developers. FFmpeg is not a compiler: all behaviors are
> implementation defined. It may make a difference later for
> performance-critical cases.

Please remember to reply to the list. I don't know what software you are
using; for good software it should be the default.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200122/0d0927f1/attachment.sig>