[FFmpeg-devel] [PATCH] avformat/mov: update extensions

[Carl Eugen Hoyos]

Am Mo., 27. Jan. 2020 um 18:07 Uhr schrieb Gyan <ffmpeg at gyani.pro>:
>
>
>
> On 27-01-2020 10:22 pm, Carl Eugen Hoyos wrote:
> > Am Mo., 27. Jan. 2020 um 17:50 Uhr schrieb Gyan <ffmpeg at gyani.pro>:
> >>
> >>
> >> On 27-01-2020 09:55 pm, Carl Eugen Hoyos wrote:
> >>> Am Mo., 27. Jan. 2020 um 17:10 Uhr schrieb Gyan <ffmpeg at gyani.pro>:
> >>>>
> >>>> On 27-01-2020 09:04 pm, Carl Eugen Hoyos wrote:
> >>>>> Am Mo., 27. Jan. 2020 um 11:31 Uhr schrieb Gyan Doshi <ffmpeg at gyani.pro>:
> >>>>>> Added all extensions used by the mov muxer family
> >>>>>> ---
> >>>>>>     libavformat/mov.c | 2 +-
> >>>>>>     1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>>>
> >>>>>> diff --git a/libavformat/mov.c b/libavformat/mov.c
> >>>>>> index 589576b529..21a5a0180e 100644
> >>>>>> --- a/libavformat/mov.c
> >>>>>> +++ b/libavformat/mov.c
> >>>>>> @@ -8073,7 +8073,7 @@ AVInputFormat ff_mov_demuxer = {
> >>>>>>         .long_name      = NULL_IF_CONFIG_SMALL("QuickTime / MOV"),
> >>>>>>         .priv_class     = &mov_class,
> >>>>>>         .priv_data_size = sizeof(MOVContext),
> >>>>>> -    .extensions     = "mov,mp4,m4a,3gp,3g2,mj2",
> >>>>>> +    .extensions     = "mov,mp4,m4a,3gp,3g2,mj2,psp,m4v,m4b,ism,ismv,isma,f4v",
> >>>>> Is this supposed to fix anything?
> >>>>> I ask because iirc the demuxer does not work for files not detected or do I
> >>>>> misremember?
> >>>> Keeping the list up to date.
> >>> I believe patches should at least theoretically fix issues but imo, feel free
> >>> to remove extensions for this demuxer if it makes you feel better.
> >> I'm *adding* extensions.
> > Since you are not claiming to fix an issue (or a theoretical issue), I was
> > assuming you don't like to have an incomplete-looking list in the file.
> > If that is correct, removing it is an option, no?
> An empty list is even more incomplete.
>
> As I mentioned, the benefit is for cli users able to specify `-f ext`
> as well as `-h demuxer=ext`

I understand now.

> >>> At least the m4v suffix is not such a good idea.
> >> What does it clash with? Raw MPEG-4 Part 2 bitstreams?
> > Yes.
> Will remove.

Thank you, Carl Eugen