[FFmpeg-devel] [PATCH V1] cmdutils: fix crash if no name for "ffmpeg -h protocol"

[Paul B Mahol]

lgtm

On 1/30/20, Jun Zhao <mypopydev at gmail.com> wrote:
> From: Jun Zhao <barryjzhao at tencent.com>
>
> fix crash when used the command like:
> - ffmpeg -h protocol
> - ffmpeg -h protocol=
>
> Signed-off-by: Jun Zhao <barryjzhao at tencent.com>
> ---
>  fftools/cmdutils.c |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
> index 2284631..f0f2b4f 100644
> --- a/fftools/cmdutils.c
> +++ b/fftools/cmdutils.c
> @@ -1872,8 +1872,14 @@ static void show_help_demuxer(const char *name)
>
>  static void show_help_protocol(const char *name)
>  {
> -    const AVClass *proto_class = avio_protocol_get_class(name);
> +    const AVClass *proto_class;
>
> +    if (!name) {
> +        av_log(NULL, AV_LOG_ERROR, "No protocol name specified.\n");
> +        return;
> +    }
> +
> +    proto_class = avio_protocol_get_class(name);
>      if (!proto_class) {
>          av_log(NULL, AV_LOG_ERROR, "Unknown protocol '%s'.\n", name);
>          return;
> --
> 1.7.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".