[FFmpeg-devel] [PATCH] avformat/protocols: check protocol name before foreach

Liu Steven lq at chinaffmpeg.org
Fri Jan 31 14:14:07 EET 2020



> 在 2020年1月31日,下午8:07,Nicolas George <george at nsup.org> 写道:
> 
> Liu Steven (12020-01-31):
>> for example: https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=250
> 
> Yes, I saw it shortly afterwards. Seems misguided: same result for a
> protocol not found (normal behavior, must be handled) and for a clumsy
> programmer. I like it better when the core functions are strict, unless
> when there is a significant benefit.
> 
> Also, it is abusing an undocumented behavior.
Just more safe than without check.
I think if it return -EINVAL maybe better than NULL, is it?
> 
> Regards,
> 
> -- 
>  Nicolas George
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".

Steven
Thanks





More information about the ffmpeg-devel mailing list