[FFmpeg-devel] [PATCH 2/2] dnn_backend_native: check operand index

Michael Niedermayer michael at niedermayer.cc
Thu Jul 2 02:45:22 EEST 2020


On Wed, Jun 17, 2020 at 03:23:34AM +0000, Guo, Yejun wrote:
> 
> 
> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Carl
> > Eugen Hoyos
> > Sent: 2020年6月16日 18:57
> > To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
> > Subject: Re: [FFmpeg-devel] [PATCH 2/2] dnn_backend_native: check operand
> > index
> > 
> > 
> > 
> > > Am 16.06.2020 um 10:18 schrieb Guo, Yejun <yejun.guo at intel.com>:
> > >
> > > I personally like to always add '{}' to avoid possible mistakes when we change
> > code in the future. Some coding styles also recommend this method.
> > >
> > > I checked at http://ffmpeg.org/developer.html#Coding-Rules and do not find
> > an explicit description. But I just remembered that someone also mentioned this
> > some time ago. I'll change to this style in v2 if no support from others for my
> > style.
> > 
> > I support your style but it is only the file maintainer‘s decision.
> 
> thanks, I'll keep the V1 patch and push soon.

please also apply this to affected release branches


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200702/5401757f/attachment.sig>


More information about the ffmpeg-devel mailing list