[FFmpeg-devel] [PATCH v05] fbdetile cpu based detiling of framebuffer v05

[Lynne]

Jul 2, 2020, 22:51 by hanishkvc at gmail.com:

> v05-20200703IST0255, fbdetile, hwdownload, kmsgrab, plus
>
> Moved the core detiling logic into libavutil/fbtile.[c|h]
>

Please integrate this into hwcontext_drm. No stray files, nothing shared
between lavu and lavfi as there shouldn't be anything in lavfi in the first place.
Detiling must be done directly in the hwcontext_drm code.



> Currently it supports detiling, later will be updated to support
> tiling also using the same core funda. Currently detiling is
> supported for Intel Tile-X|Y|Yf layouts. However the logic is
> easily configurable to support additional tile layouts, in future.
>
> Inturn this is used to support detiling of hwdownload frames.
> So one can detile when capturing from a hardware context if reqd,
> provided it supports one of the intel tile-x|y|yf formats. This
> can be used to detile when using kmsgrab for example.
>
> kmsgrab updated to use GetFB2 drm api, so that format_modifier
> can be autodetected and used for detiling by hwdownload, if
> fbdetile=1 (auto mode) is used.
>

Send this as a separate patch.



>
> However if one doesn't want to use detiling during capture, one
> can use the fbdetile video filter to apply the detiling at a later
> stage as a seperate pass.
>

NAK. In case you don't realize what all my emails mean: we're not accepting
this as an optional filter in any way, shape or form. hwdownload _must_always_ detile.
It must only return an untiled image if we don't have code to detile it, and it should
emit a warning log in that case.