[FFmpeg-devel] [FFmpeg-cvslog] swscale: Add swscale input/output support for X2RGB10LE

[Wang, Fei W]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Michael Niedermayer
> Sent: Monday, July 6, 2020 7:47 AM
> To: ffmpeg-devel at ffmpeg.org
> Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] swscale: Add swscale
> input/output support for X2RGB10LE
> 
> On Fri, Jun 12, 2020 at 04:57:30PM +0000, Fei Wang wrote:
> > ffmpeg | branch: master | Fei Wang <fei.w.wang at intel.com> | Wed Apr 22
> > 13:23:02 2020 +0800| [c721b450141d6bbe1e977212a0bcb70118965c34] |
> > committer: Lynne
> >
> > swscale: Add swscale input/output support for X2RGB10LE
> >
> > Signed-off-by: Fei Wang <fei.w.wang at intel.com>
> >
> > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=c721b45014
> > > 1d6bbe1e977212a0bcb70118965c34
> > ---
> >
> >  libswscale/input.c                       | 13 ++++++++++++-
> >  libswscale/output.c                      | 14 ++++++++++++++
> >  libswscale/utils.c                       |  1 +
> >  libswscale/yuv2rgb.c                     | 22 ++++++++++++++++++++++
> >  tests/ref/fate/filter-pixfmts-copy       |  1 +
> >  tests/ref/fate/filter-pixfmts-crop       |  1 +
> >  tests/ref/fate/filter-pixfmts-field      |  1 +
> >  tests/ref/fate/filter-pixfmts-fieldorder |  1 +
> >  tests/ref/fate/filter-pixfmts-hflip      |  1 +
> >  tests/ref/fate/filter-pixfmts-il         |  1 +
> >  tests/ref/fate/filter-pixfmts-null       |  1 +
> >  tests/ref/fate/filter-pixfmts-pad        |  1 +
> >  tests/ref/fate/filter-pixfmts-scale      |  1 +
> >  tests/ref/fate/filter-pixfmts-transpose  |  1 +
> >  tests/ref/fate/filter-pixfmts-vflip      |  1 +
> >  15 files changed, 60 insertions(+), 1 deletion(-)
> 
> This fails on big endian (mips qemu)
> 
> stuff like:
Thanks, I will try to setup mips qumu to check this. Mostly like it shouldn't execute little endian case on big endian enviroment.

@Andriy Gelman, I am not sure do we already have big endian test environment in patchwork fate test now? if not, we may consider to add it, so that we can catch the fail before patch merge.
> 
> --- src/tests/ref/fate/filter-pixdesc-x2rgb10le 2020-07-05 19:59:34.522597589
> +0200
> +++ tests/data/fate/filter-pixdesc-x2rgb10le    2020-07-06 00:35:27.242235755
> +0200
> @@ -1 +1 @@
> -pixdesc-x2rgb10le    98d697ed4668daf535163d5e08c903bb
> +pixdesc-x2rgb10le   1a608f8a86f297d6c560610927f91adb
> Test filter-pixdesc-x2rgb10le failed. Look at tests/data/fate/filter-pixdesc-
> x2rgb10le.err for details.
> src/tests/Makefile:255: recipe for target 'fate-filter-pixdesc-x2rgb10le' failed
> make: *** [fate-filter-pixdesc-x2rgb10le] Error 1
> 
> 
> --- src/tests/ref/fate/filter-pixfmts-field     2020-07-05 19:59:34.522597589
> +0200
> +++ tests/data/fate/filter-pixfmts-field        2020-07-06 00:37:10.830283380
> +0200
> @@ -80,7 +80,7 @@
>  rgba64be            23c8c0edaabe3eaec89ce69633fb0048
>  rgba64le            dfdba4de4a7cac9abf08852666c341d3
>  uyvy422             1c49e44ab3f060e85fc4a3a9464f045e
> -x2rgb10le           a7a5dcdfe1d4b6bd71e40b01c735f144
> +x2rgb10le           05495c886b55fa5476374606f0148d68
>  xyz12be             d2fa69ec91d3ed862f2dac3f8e7a3437
>  xyz12le             02bccd5e0b6824779a1f848b0ea3e3b5
>  ya16be              40403b5277364777e0671da4d38e01ac
> Test filter-pixfmts-field failed. Look at tests/data/fate/filter-pixfmts-field.err for
> details.
> src/tests/Makefile:255: recipe for target 'fate-filter-pixfmts-field' failed
> make: *** [fate-filter-pixfmts-field] Error 1
> 
> 
> --- src/tests/ref/fate/filter-pixfmts-hflip     2020-07-05 19:59:34.522597589
> +0200
> +++ tests/data/fate/filter-pixfmts-hflip        2020-07-06 00:37:11.306283604
> +0200
> @@ -77,7 +77,7 @@
>  rgba                51961c723ea6707e0a410cd3f21f15d3
>  rgba64be            c910444019f4cfbf4d995227af55da8d
>  rgba64le            0c810d8b3a6bca10321788e1cb145340
> -x2rgb10le           9f99dce306383daf25cd1542b2517fef
> +x2rgb10le           583b0f0ae2642ddf24ab5abacba1bbc1
>  xyz12be             25f90259ff8a226befdaec3dfe82996e
>  xyz12le             926c0791d59aaff61b2778e8ada3316d
>  ya16be              d5b342355bdd9e3197e01b13b7c6301e
> TEST    vsynth2-dnxhd-1080i
> Test filter-pixfmts-hflip failed. Look at tests/data/fate/filter-pixfmts-hflip.err for
> details.
> src/tests/Makefile:255: recipe for target 'fate-filter-pixfmts-hflip' failed
> make: *** [fate-filter-pixfmts-hflip] Error 1
> TEST    vsynth2-dnxhd-1080i-10bit
> TEST    vsynth2-dnxhd-1080i-colr
> TEST    vsynth2-dnxhd-hr-lb-mov
> TEST    vsynth2-dnxhd-hr-sq-mov
> --- src/tests/ref/fate/filter-pixfmts-copy      2020-07-05 19:59:34.522597589
> +0200
> +++ tests/data/fate/filter-pixfmts-copy 2020-07-06 00:37:11.622283754
> +++ +0200
> @@ -80,7 +80,7 @@
>  rgba64be            ae2ae04b5efedca3505f47c4dd6ea6ea
>  rgba64le            b91e1d77f799eb92241a2d2d28437b15
>  uyvy422             3bcf3c80047592f2211fae3260b1b65d
> -x2rgb10le           b0a0c8056521beeaa3fea4985ca87176
> +x2rgb10le           6cb140adba429c301fecf464ed604506
>  xyz12be             a1ef56bf746d71f59669c28e48fc8450
>  xyz12le             831ff03c1ba4ef19374686f16a064d8c
>  ya16be              37c07787e544f900c87b853253bfc8dd
> Test filter-pixfmts-copy failed. Look at tests/data/fate/filter-pixfmts-copy.err
> for details.
> src/tests/Makefile:255: recipe for target 'fate-filter-pixfmts-copy' failed
> make: *** [fate-filter-pixfmts-copy] Error 1
> TEST    vsynth2-dnxhd-hr-hq-mov
> 
> 
> 
> [...]
> --
> Michael     GnuPG fingerprint:
> 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> If the United States is serious about tackling the national security threats
> related to an insecure 5G network, it needs to rethink the extent to which it
> values corporate profits and government espionage over security.-Bruce
> Schneier