[FFmpeg-devel] [PATCH] libavutil/video_enc_params: add block type

[Anton Khirnov]

Quoting Yongle Lin (2020-07-06 23:08:17)
> add block type field to AVVideoBlockParams so we could either export or visualize it later.
> ---
>  libavutil/video_enc_params.h | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)

We generally require new APIs to be immediately useful. So in this case,
there should also be a patch that makes some decoder export those
fields.

> 
> diff --git a/libavutil/video_enc_params.h b/libavutil/video_enc_params.h
> index 43fa443154..55b9fc4031 100644
> --- a/libavutil/video_enc_params.h
> +++ b/libavutil/video_enc_params.h
> @@ -101,6 +101,21 @@ typedef struct AVVideoEncParams {
>      int32_t delta_qp[4][2];
>  } AVVideoEncParams;
>  
> +typedef struct MacroBlockType {
> +    /**
> +     * Is intra prediction
> +     */
> +    int intra;
> +    /**
> +     * Skip flag
> +     */
> +    int skip;

These structures are stored per-block, so it seems pretty wasteful to
spend a whole int (4 bytes) when only one bit is used.

-- 
Anton Khirnov