[FFmpeg-devel] [PATCH v1 1/3] doc/developer.texi: Improvements in "Submitting patches" section.

Michael Niedermayer michael at niedermayer.cc
Thu Jul 9 23:39:41 EEST 2020


On Thu, Jul 09, 2020 at 02:01:45AM +0200, Manolis Stamatogiannakis wrote:
> On Tue, 7 Jul 2020 at 16:00, Nicolas George <george at nsup.org> wrote:
> 
> > Manolis Stamatogiannakis (12020-07-05):
[...]
> > > +Additionally, it is recommended to register for a
> > > + at uref{https://patchwork.ffmpeg.org, patchwork account}.
> > > +This will allow you to mark previous version of your patches as
> > "Superseded",
> > > +and reduce the chance of someone spending time to review a stale patch.
> >
> > Is interacting with Patchwork to become mandatory when submitting
> > patches?
> >
> 
> Nicolas, why would you ever interpret "recommended" as mandatory? I think
> it's as clear as it gets that it is not mandatory.
> 
> Again, this is a good practice which was not mentioned in the
> documentation. I have no attachment whatsoever to the tool, or intention to
> impose it to anyone.
> 

> @Michael Niedermayer, since you seem to be the most involved with patchwork
> in the thread, what would be better for this? Keep the wording as a
> recommendation, or to move it outside the list as purely informational text?

I think there are 2 aspects here
First is a "mostly automatic patchwork with only people who want to play with
it obtaining accounts and doing something with them" vs one where its
recommanded to get accounts
These are 2 different philosophies ;)

Second is, time vs time
Is the gain from manually working with patchwork saving us more time elsewhere while
we achieve the same quality of code?

and Third
Can we not automate whatever we would do manually ?

And describing the actual cases with examples what is wrong and needs manual
update would be interresting.

Are these caseses that are clear to human but unclear to a computer ?
or we are just missing a line or 2 in the script ?
or are they maybe unclear to humans too ? which could then lead 
a discussion on how to make that clear to humans first ...

I think its needed to understand where automation fails to really discuss
this all

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200709/f4162ce5/attachment.sig>


More information about the ffmpeg-devel mailing list