[FFmpeg-devel] [PATCH] avformat/libssh: add AVOptions for authentication

[Nicolas George]

James Almer (12020-07-14):
> Perhaps this should instead be implemented as an AV_OPT_TYPE_DICT option
> that can accept anything you would otherwise pass as part of the url, so
> user, pass, port, etc.

It makes things more complicated for us (accessing a dictionary instead
of options directly), for API users (setting the dictionary plus the
option itself) and for command-line users (extra level of escaping).

Unless we expect the list of things obtained from the URL to grow in the
future, which is unlikely to say the least, I see no benefit compared to
just adding all this at once.

Am I missing something? What benefit would you expect?

On the other hand, since a lot of protocols do some kind of
av_url_split(), it makes sense to factor it.

Why not add all these fields to URLContext and have ffurl_connect()
split the URL, using options if they are available?

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200714/de622b4c/attachment.sig>