[FFmpeg-devel] [PATCH v2 1/6] avcodec/golomb: Don't emit error message in get_ue_golomb

Andreas Rheinhardt andreas.rheinhardt at gmail.com
Tue Jul 14 23:19:49 EEST 2020


Said error message is not very informative and lacked a proper logging
context; furthermore, many callers already provided more descriptive
error messages of their own. So just drop this one.

Suggested-by: James Almer <jamrial at gmail.com>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
---
 libavcodec/golomb.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/libavcodec/golomb.h b/libavcodec/golomb.h
index 7fd46a91bd..1f988d74aa 100644
--- a/libavcodec/golomb.h
+++ b/libavcodec/golomb.h
@@ -87,10 +87,8 @@ static inline int get_ue_golomb(GetBitContext *gb)
         int log = 2 * av_log2(buf) - 31;
         LAST_SKIP_BITS(re, gb, 32 - log);
         CLOSE_READER(re, gb);
-        if (log < 7) {
-            av_log(NULL, AV_LOG_ERROR, "Invalid UE golomb code\n");
+        if (log < 7)
             return AVERROR_INVALIDDATA;
-        }
         buf >>= log;
         buf--;
 
-- 
2.20.1



More information about the ffmpeg-devel mailing list