[FFmpeg-devel] [PATCH 2/2] swscale/tests/swscale: use codes < 128 for indicating erros

[Martin Storsjö]

On Thu, 16 Jul 2020, Michael Niedermayer wrote:

> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
> libswscale/tests/swscale.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libswscale/tests/swscale.c b/libswscale/tests/swscale.c
> index 845ced61bb..9c0b5a4b11 100644
> --- a/libswscale/tests/swscale.c
> +++ b/libswscale/tests/swscale.c
> @@ -248,7 +248,7 @@ end:
>         if (dstStride[i])
>             av_free(dst[i]);
> 
> -    return res;
> +    return res & 127;
> }

Is there a valuable distinction between the different return values in 
this test tool so far? Because this code will e.g. fail to return a proper 
error return code if res happens to be -128.

Otherwise this could be made into e.g. "return !!res;" or something like 
that.

// Martin