[FFmpeg-devel] [PATCH] adtsenc: Add ability to specify MPEG ID

[Marvin Scholz]

On 16 Jul 2020, at 18:11, Hendrik Leppkes wrote:

> On Thu, Jul 16, 2020 at 5:28 PM Kieran Kunhya <kierank at obe.tv> wrote:
>>
>> On Thu, 16 Jul 2020 at 16:25, Marvin Scholz <epirat07 at gmail.com> wrote:
>>
>>> ---
>>>
>>> This stills lacks docs, as I first want an overall opinion on this
>>> approach or possible other solutions I should choose for this.
>>>
>>
>> What uses this?
>>
>
> In my experience some older devices also require the type set to MPEG2.
>
> For the patch itself -
> Its generally a good idea to be able to specify it, but i'm not sure
> about the option chosen. Its a single bit value for swapping between
> mpeg2 and mpeg4, maybe it should just be boolean?
>

Sure, thats of course possible too. I have no strong opinions about that
at all. (It's just mostly that it could not come up with a good idea
for a boolean option name for this)

> - Hendrik
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".