[FFmpeg-devel] [PATCH v3 1/2] avcodec/put_bits: Parametrize bit buffer type

[Paul B Mahol]

Please revert immediately:

libavcodec/gif.c:347:40: warning: incompatible pointer types passing
'void (PutBitContext *, int, BitBuf)' (aka 'void (struct PutBitContext
*, int, unsigned long)') to parameter of type 'void (*)(struct
PutBitContext *, int, unsigned int)' [-Wincompatible-pointer-types]
                       12, FF_LZW_GIF, put_bits);
                                       ^~~~~~~~
libavcodec/lzw.h:58:32: note: passing argument to parameter 'lzw_put_bits' here
                        void (*lzw_put_bits)(struct


On 7/19/20, Michael Niedermayer <michael at niedermayer.cc> wrote:
> On Sat, Jul 18, 2020 at 04:53:02PM +0200, Steinar H. Gunderson wrote:
>> Preparatory patch for making the bit buffer different size on different
>> platforms; make a typedef and make all the hardcoded sizes into
>> expressions
>> deriving from this size.
>>
>> No functional change; generated assembler is near-identical.
>> ---
>>  libavcodec/mpegvideo_enc.c |  2 +-
>>  libavcodec/put_bits.h      | 95 +++++++++++++++++++++-----------------
>>  2 files changed, 53 insertions(+), 44 deletions(-)
>
> will apply patchset after some more tests
>
> thx
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> If the United States is serious about tackling the national security threats
>
> related to an insecure 5G network, it needs to rethink the extent to which
> it
> values corporate profits and government espionage over security.-Bruce
> Schneier
>