[FFmpeg-devel] [PATCH] avformat/internal: Remove wrong documentation
Anton Khirnov
anton at khirnov.net
Mon Jul 27 12:54:34 EEST 2020
Quoting Andreas Rheinhardt (2020-07-27 06:13:05)
> Has apparently been copied from ff_choose_timebase() in commit
> a45cf639e6fb8c86aff91a00970060cd0be401c9.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> ---
> Btw: There is exactly one user of this, namely the MXF muxer.
> Should this be moved to mxfenc.c? The same issue exists for
> ff_choose_timebase(), which is only used by the nut muxer.
>
> libavformat/internal.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/libavformat/internal.h b/libavformat/internal.h
> index 17a6ab07d3..a2eac3250d 100644
> --- a/libavformat/internal.h
> +++ b/libavformat/internal.h
> @@ -538,9 +538,6 @@ enum AVCodecID ff_get_pcm_codec_id(int bps, int flt, int be, int sflags);
> */
> AVRational ff_choose_timebase(AVFormatContext *s, AVStream *st, int min_precision);
>
> -/**
> - * Chooses a timebase for muxing the specified stream.
> - */
> enum AVChromaLocation ff_choose_chroma_location(AVFormatContext *s, AVStream *st);
>
> /**
> --
> 2.20.1
I'd say yes.
Patch looks ok either way.
--
Anton Khirnov
More information about the ffmpeg-devel
mailing list