[FFmpeg-devel] [PATCH] lavf/srt: fix build fail when used the libsrt 1.4.1

[mypopy at gmail.com]

On Sat, Jul 18, 2020 at 8:31 PM mypopy at gmail.com <mypopy at gmail.com> wrote:
>
> On Thu, Jul 16, 2020 at 9:35 AM mypopy at gmail.com <mypopy at gmail.com> wrote:
> >
> > On Tue, Jul 14, 2020 at 9:47 PM Moritz Barsnick <barsnick at gmx.net> wrote:
> > >
> > > On Sun, Jul 12, 2020 at 22:44:46 +0800, mypopy at gmail.com wrote:
> > > > Maybe I give an inaccurate description in the commit message, in fact,
> > > > libsrt 1.4.1 remove the SRTO_STRICTENC/SRTO_SMOOTHER option, it's will
> > > > lead to FFmpeg build fail when using libsrt  version >= 1.4.1
> > >
> > > I don't mind you description. Yet your code change references 1.4.1:
> > >     SRT_VERSION_VALUE >= 0x010401
> > > while I am trying to make the point that 1.4.0 also needs this change
> > > (or 1.3.0 in one case, which is already ensured by #if).
> > >
> >
> > After double-check, I think the patch is Ok, in fact, libsrt keeps the
> > deprecated SRTO_STRICTENC/SRTO_SMOOTHER options in srt.h (inclued the
> > options in libsrt 1.3.3/1.3.4/1.4.0) until commit
> > 0e2201aff6b379979cec43fee5e8f162717f6346 , so FFmpeg build with libsrt
> > 1.3.3/1.3.4/1.4.0 is OK with the patch.
> Ping
I'll apply it tomorrow if don't object, thx