[FFmpeg-devel] [PATCH v3 1/2] avformat/url: rework for trim_double_dot_url

Nicolas George george at nsup.org
Mon Jul 27 16:47:21 EEST 2020


Steven Liu (12020-07-27):
> use two buffer for storage the path and node of URI
> remove the last node of the path if the next node is ..
> change the static strings to dynamic alloc space by size argument.

?!?!??!!!?

Why do you think you need extra buffers?

This patch turns a rather straightforward task into a nightmare of
string copies.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200727/43dbff5e/attachment.sig>


More information about the ffmpeg-devel mailing list