[FFmpeg-devel] [PATCH] avfilter/vf_xcam: add xcam video filter
Zong, Wei
wei.zong at intel.com
Fri Jul 31 10:02:53 EEST 2020
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Steven
> Liu
> Sent: Thursday, July 30, 2020 7:04 PM
> To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_xcam: add xcam video filter
>
> Zong, Wei <wei.zong at intel.com> 于2020年7月30日周四 下午6:00写道：
> >
> > Someone opened an issue https://github.com/intel/libxcam/issues/729 they
> want to use a FFmpeg video filter pipeline to do multiple decoder, stitching and
> encoder.
> >
> > Those 3rd party libs are not necessary for stitching and most image processing
> functions. By default these 3rd libs are disabled.
> >
> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> > mypopy at gmail.com
> > Sent: Thursday, July 30, 2020 5:34 PM
> > To: FFmpeg development discussions and patches
> > <ffmpeg-devel at ffmpeg.org>
> > Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_xcam: add xcam video
> > filter
> >
> > On Thu, Jul 30, 2020 at 5:15 PM mypopy at gmail.com <mypopy at gmail.com>
> wrote:
> > >
> > > On Thu, Jul 30, 2020 at 5:12 PM Nicolas George <george at nsup.org> wrote:
> > > >
> > > > zongwave (12020-07-31):
> > > > > From: Yinhang Liu <yinhangx.liu at intel.com>
> > > > >
> > > > > xcam filter is a wrapper of libxcam project which supports 360
> > > > > video stitching, automotive surround view stitching, digital
> > > > > video stabilization (DVS), Wide dynamic range (WDR), wavelet noise
> reduction, 3D noise reduction, etc.
> > > >
> > > > Hi. Thanks for the patch. But it seems to have been generated in a
> > > > strange way, with double insertion marks. Did you commit your
> > > > changes and then use git format-patch or git send-email?
> > > >
> > > > Regards,
> > > >
> > > > --
> > > > Nicolas George
> > >
> > > The other thing is, I found libxcam
> > > (https://github.com/intel/libxcam)
> > > depend on a lot of 3rd libs
> > > "
> > > If --enable-gst, need install libgstreamer1.0-dev,
> > > libgstreamer-plugins-base1.0-dev If --enable-aiq, need get
> > > ia_imaging lib which we don't support If --enable-libcl, need
> > > compile or install OpenCL driver If --enable-opencv, suggest OpenCV
> > > versions [3.0.0 -
> > > 4.0.0) (or: OpenCV Wiki) If --enable-render, need compile
> > > OpenSceneGraph library with configure option
> > > "-DOSG_WINDOWING_SYSTEM=X11"
> > > If --enable-gles, need to install Mesa3D library If --enable-vulkan,
> > > need to install Mesa3D library If --enable-avx512, need to install
> > > GCC version > 4.9 ( CPUs With
> > > AVX-512 required)
> > > If --enable-dnn, need to compile OpenVino inference-engine If
> > > --enable-json, need to install json.hpp "
> > > Is it a good idea to wrap a lib like this in AVFilter?
> >
> > My confusion is, where is the boundary of FFmpeg？
> > in my personal opinion, libxcam is not a self-contained library.
> > _______________________________________________
>
> 1, Wei, DO NOT topic reply email.
OK, I will not do this again. Thank you.
> 2. after git am your patch, when i use git show,
>
> the last message bellow:
>
>
> commit 368d43d3537e608904c7793b12cf2f4de0527e7a (HEAD -> master)
> Author: Yinhang Liu <yinhangx.liu at intel.com>
> Date: Thu Jul 30 13:45:39 2020 +0800
>
> avfilter/vf_xcam: add xcam video filter
>
> xcam filter is a wrapper of libxcam project which supports 360 video stitching,
> automotive surround view stitching, digital video stabilization (DVS),
> Wide dynamic range (WDR), wavelet noise reduction, 3D noise reduction, etc.
>
> libxcam library optimized algorithms by AVX, GLES and Vulkan depends on
> hardware configuration to get good performance.
>
> libxcam project is hosted at https://github.com/intel/libxcam
> please refer to https://github.com/intel/libxcam/wiki/Build to build libxcam
> library.
>
> To enable xcam video filter, configure FFmpeg with option
> --enable-libxcam.
>
> Here are the features provided by xcam video filter:
> - stitch CPU|GLES|Vulkan stitching
> - stitchcl OpenCL stitching
> - fisheye Fisheye calibration
> - 3dnr 3D denoising
> - waveletnr Wavelet denoising
> - dvs Digital video stabilization
> - defog Fog removal
>
> Use 'ffmpeg -h filter=xcam' to get the common parameters, stitch and
> stitchcl have private parameters, use 'params=help=1' to get the private
> parameters. For more detailed test cases posted at:
> https://github.com/intel/libxcam/wiki/Tests#1-ffmpeg-xcam.
>
> Reviewed-by: Zong Wei <wei.zong at intel.com>
>
> diff --git a/patchset/0057-avfilter-vf_xcam-add-xcam-video-filter.patch
> b/patchset/0057-avfilter-vf_xcam-add-xcam-video-filter.patch
> new file mode 100644
> index 0000000000..0c3b291dfe
> --- /dev/null
> +++ b/patchset/0057-avfilter-vf_xcam-add-xcam-video-filter.patch
> @@ -0,0 +1,543 @@
> +From f35fa5e17a2916e9342b58a989dc94e88906dfca Mon Sep 17 00:00:00
> 2001
> +From: Yinhang Liu <yinhangx.liu at intel.com>
> +Date: Thu, 30 Jul 2020 13:33:37 +0800
> +Subject: [PATCH] avfilter/vf_xcam: add xcam video filter
> +
> (base) liuqi05:ffmpeg liuqi$ ls patchset/ 0057-avfilter-vf_xcam-add-xcam-video-
> filter.patch
> (base) liuqi05:ffmpeg liuqi$
>
>
> the patch have create a new patch named:
> patchset/0057-avfilter-vf_xcam-add-xcam-video-filter.patch
> I think maybe you want submit that patch:
> patchset/0057-avfilter-vf_xcam-add-xcam-video-filter.patch
> Am i right?
>
Yes, you are right. I applied the original patch in an internal CI build to run regression test. I Modified the commit message and formatted a new patch.
I'll fix the issue send a new patch again.
> Chinese Font, just translation the English content to Chinese font.
> you can ignore these text if you are not Chinese,
>
> 宗伟，
> 你的patch被合并之后，并没有创建libavfilter/vf_xcam.c,而是创建了一个
> patch，叫patchset/0057-avfilter-vf_xcam-add-xcam-video-filter.patch
> 你是想创建一个patch给ffmpeg，还是说你想提交patchset/0057-avfilter-
> vf_xcam-add-xcam-video-filter.patch给ffmpeg？
>
>
> Thanks
> Steven
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email ffmpeg-devel-request at ffmpeg.org
> with subject "unsubscribe".
More information about the ffmpeg-devel
mailing list