[FFmpeg-devel] [PATCH 1/2] avcodec: Add AV_CODEC_FLAG2_FAST_UNSAFE, move unsafe uses of FAST to it

[Paul B Mahol]

On 6/2/20, Michael Niedermayer <michael at niedermayer.cc> wrote:
> On Mon, Jun 01, 2020 at 02:30:20PM +0100, Kieran Kunhya wrote:
>> On Mon, 1 Jun 2020 at 14:02, Anton Khirnov <anton at khirnov.net> wrote:
>>
>> > Quoting Paul B Mahol (2020-05-29 18:46:18)
>> > > I see no aggression at all here.
>> >
>> > Same here. People have disagreeing opinions and are expressing them.
>> > That does not imply aggression or uncivility.
>> >
>>
>> There is no aggression here.
>
> So. let me clarify this as it seems several people didnt notice it.
>
> Calling a submitted feature a bug, is aggression.
>
> A bug is unintended behavior. The user would turn this only on
> when its intended
>
> This thread started from me suggesting the change and asking about better
> suggestions
>     I suggest to add a AV_CODEC_FLAG2_FAST_UNSAFE and split the current
>     uses of the flag up between the 2
>
>     will submit a patch doing that unless i hear objections / a better
>     suggestion.
>
> Zero replies
>
> Please, if you see an issue in a patch or suggestion in the future,
> explain that issue, write a clear argument.
> Simply caling a feature a bug or adding your agreement below such
> statement is not helpfull. Its even less helpfull than just saying
> you are against it.
>
> If you say you are against it i can count that, if you say its something
> that it is not what would that tell me ?
>

Get it a rest and remove this unsafe code at once.

> Thanks
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> If a bugfix only changes things apparently unrelated to the bug with no
> further explanation, that is a good sign that the bugfix is wrong.
>