[FFmpeg-devel] [PATCH] avfilter: add afwtdn filter

Nicolas George george at nsup.org
Tue Jun 2 16:43:19 EEST 2020


Lou Logan (12020-05-31):
> Got any suggestions? We have 3 existing "audio-3 letter algorithm name-
> denoise" filters so there is sort of a naming convention already.

I do not consider something that was pushed by a single developer,
mostly without review, to be a binding convention.

And we probably should not have several filters in the first place, we
should have different modes of operation for the same filter.

In any case, the name should reflect what is done, not how it is done:
the not the algorithm. The doc should explain it too. It should explain
in what cases this filter is better than the others and in what cases it
is not.

We have been lax in the past, but that does not mean we should be lax
now or in the future. This filter should not be pushed unless these
concerns about user interface are addressed.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200602/bf8d1c8d/attachment.sig>


More information about the ffmpeg-devel mailing list