[FFmpeg-devel] [PATCH] avfilter/avfilter: add sample_count_in and sample_count_out

[Nicolas George]

Paul B Mahol (12020-06-03):
> Why so? Just to be beaten again by same person which would reject this
> same patch.

I was not the first one to reject a patch because in introduces APIs or
fields without users, but I think it is a good policy.

> > "Number of samples already sent through the link" seems more natural.
> I copy pasted sentence for frames above. Should it be changed too?

I do not think it matters much.
> 
> Above frame counters are not unsigned. Why to do different.

If I had noticed it when they were added, I would have suggested they be
unsigned too. Signed arithmetic is more tricky, and compiler optimize it
less well: if something does not need to be negative, let it be
unsigned.

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200603/46e07f24/attachment.sig>