[FFmpeg-devel] [PATCH v2 1/3] lavu/pix_fmt: add new pixel format x2rgb10

[Lynne]

Jun 11, 2020, 17:26 by dev at lynne.ee:

> Jun 2, 2020, 08:30 by fei.w.wang at intel.com:
>
>>
>>
>>> -----Original Message-----
>>> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Wang,
>>> Fei W
>>> Sent: Friday, May 15, 2020 2:58 PM
>>> To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
>>> Subject: Re: [FFmpeg-devel] [PATCH v2 1/3] lavu/pix_fmt: add new pixel
>>> format x2rgb10
>>>
>>>
>>> > -----Original Message-----
>>> > From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
>>> > Lynne
>>> > Sent: Wednesday, May 13, 2020 7:19 AM
>>> > To: FFmpeg development discussions and patches <ffmpeg-
>>> > devel at ffmpeg.org>
>>> > Subject: Re: [FFmpeg-devel] [PATCH v2 1/3] lavu/pix_fmt: add new pixel
>>> > format x2rgb10
>>> >
>>> > May 12, 2020, 23:42 by sw at jkqxz.net:
>>> >
>>> > > On 12/05/2020 22:42, Lynne wrote:
>>> > >
>>> > >> Apr 22, 2020, 06:28 by fei.w.wang at intel.com:
>>> > >>
>>> > >>>> -----Original Message-----
>>> > >>>> From: Wang, Fei W <fei.w.wang at intel.com>
>>> > >>>> Sent: Wednesday, April 22, 2020 1:23 PM
>>> > >>>> To: ffmpeg-devel at ffmpeg.org
>>> > >>>> Cc: Wang, Fei W <fei.w.wang at intel.com>
>>> > >>>> Subject: [PATCH v2 1/3] lavu/pix_fmt: add new pixel format
>>> > >>>> x2rgb10
>>> > >>>>
>>> > >>>> The format is packed RGB with each channel 10 bits available and
>>> > >>>> include 2 bits unused.
>>> > >>>>
>>> > >>>> Signed-off-by: Fei Wang <fei.w.wang at intel.com>
>>> > >>>>
>>> > >>
>>> > >> Ping on this patch? I kind of need it to support 10 bit Vulkan sw_formats.
>>> > >> I'm happy with the name as-is.
>>> > >>
>>> > >
>>> > > Yes, but we probably need to reach a consensus on whether we are
>>> > accepting the addition of these V210-like packed formats first - there
>>> > were voices against it last time this was raised.
>>> > >
>>> > > I am in favour of allowing it because it is a common buffer format
>>> > > used in
>>> > both graphics and display hardware, and appears in pretty much all
>>> > related APIs (OpenGL, OpenCL, Vulkan, KMS, D3D).
>>> > >
>>> >
>>> > Same. With it, we would be able to support kmsgrab from 10bit
>>> > displays, which are becoming more and more popular.
>>> Glad to know this format can be used for Vulkan 10bit display. Sounds like this
>>> format can bring more benefit to ffmpeg. Ping for other comments.
>>>
>> Hi Kindly ping, is there any other concern of this format? Tks.
>>
>
> Planning to push this tomorrow so I can start working on supporting it in Vulkan.
>

Pushed.
Thanks for adding swscale support for it as well, it makes debugging easier.