[FFmpeg-devel] [PATCH] avcodec/ccaption_dec: rework non-real-time mode by delaying subtitles

[Paul B Mahol]

On 6/18/20, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> Am Do., 18. Juni 2020 um 22:10 Uhr schrieb Paul B Mahol <onemda at gmail.com>:
>>
>> On 6/18/20, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>> > Am Do., 18. Juni 2020 um 22:05 Uhr schrieb Paul B Mahol
>> > <onemda at gmail.com>:
>> >>
>> >> So it give similar output as visual output of real-time mode.
>> >>
>> >> FATE results changes for non-realtime mode so it is updated.
>> >
>> >
>> >> diff --git a/tests/ref/fate/sub-cc b/tests/ref/fate/sub-cc
>> >> index 2b30a35be0..0528c846d4 100644
>> >> --- a/tests/ref/fate/sub-cc
>> >> +++ b/tests/ref/fate/sub-cc
>> >> @@ -11,5 +11,5 @@ Style:
>> >> Default,Monospace,16,&Hffffff,&Hffffff,&H0,&H0,0,0,0,0,100,100,0,0,3,1,0,
>> >>
>> >>  [Events]
>> >>  Format: Layer, Start, End, Style, Name, MarginL, MarginR, MarginV,
>> >> Effect, Text
>> >> -Dialogue:
>> >> 0,0:00:12.36,0:00:40.83,Default,,0,0,0,,{\an7}{\pos(38,44)}({\i1}
>> >> inaudible radio chatter{\i0} )
>> >> -Dialogue:
>> >> 0,0:00:40.83,0:00:59.07,Default,,0,0,0,,{\an7}{\pos(38,28)}({\i1}
>> >> inaudible radio chatter{\i0} )\N{\an7}{\pos(38,44)}>> Safety remains
>> >> our
>> >> number one
>> >> +Dialogue:
>> >> 0,0:00:40.83,0:00:59.07,Default,,0,0,0,,{\an7}{\pos(38,44)}({\i1}
>> >> inaudible radio chatter{\i0} )
>> >> +Dialogue:
>> >> 0,0:00:59.07,0:01:17.31,Default,,0,0,0,,{\an7}{\pos(38,28)}({\i1}
>> >> inaudible radio chatter{\i0} )\N{\an7}{\pos(38,44)}>> Safety remains
>> >> our
>> >> number one
>> >> diff --git a/tests/ref/fate/sub-cc-scte20
>> >> b/tests/ref/fate/sub-cc-scte20
>> >> index be28084887..47ad05db72 100644
>> >> --- a/tests/ref/fate/sub-cc-scte20
>> >> +++ b/tests/ref/fate/sub-cc-scte20
>> >> @@ -11,6 +11,6 @@ Style:
>> >> Default,Monospace,16,&Hffffff,&Hffffff,&H0,&H0,0,0,0,0,100,100,0,0,3,1,0,
>> >>
>> >>  [Events]
>> >>  Format: Layer, Start, End, Style, Name, MarginL, MarginR, MarginV,
>> >> Effect, Text
>> >> -Dialogue:
>> >> 0,0:00:00.00,0:00:01.44,Default,,0,0,0,,{\an7}{\pos(48,182)}BESIDES THE
>> >> -Dialogue:
>> >> 0,0:00:01.43,0:00:03.93,Default,,0,0,0,,{\an7}{\pos(38,166)}\hBESIDES
>> >> THE
>> >> \N{\an7}{\pos(38,197)}SPENDING AND THIS, IS THAT CAR
>> >> -Dialogue:
>> >> 0,0:00:03.94,0:00:06.31,Default,,0,0,0,,{\an7}{\pos(38,182)}SPENDING
>> >> AND
>> >> THIS, IS THAT CAR \N{\an7}{\pos(38,197)}MANUFACTURERS ARE ABOUT AS
>> >> +Dialogue:
>> >> 0,0:00:01.43,0:00:03.93,Default,,0,0,0,,{\an7}{\pos(48,182)}BESIDES THE
>> >> +Dialogue:
>> >> 0,0:00:03.94,0:00:06.31,Default,,0,0,0,,{\an7}{\pos(38,166)}\hBESIDES
>> >> THE
>> >> \N{\an7}{\pos(38,197)}SPENDING AND THIS, IS THAT CAR
>> >> +Dialogue:
>> >> 0,0:00:06.31,0:00:08.68,Default,,0,0,0,,{\an7}{\pos(38,182)}SPENDING
>> >> AND
>> >> THIS, IS THAT CAR \N{\an7}{\pos(38,197)}MANUFACTURERS ARE ABOUT AS
>> >
>> > Were both outputs completely wrong before?
>> >
>>
>> Can't tell. samples are small and without audio so no way to check.
>
> The longest variant of the first sample file is now in samples/MPEG2/subcc
> File name is Closedcaption_rollup.ts
>

Thanks.

Fixed patch to only delay for  pop-on captions.
Thus fate does not need a change.
For others modes delaying is not needed.

> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".