[FFmpeg-devel] [PATCH 3/4] avutil/timecode: add function av_timecode_get_smpte_by_tc_string()

[lance.lmwang at gmail.com]

On Sat, Jun 20, 2020 at 02:51:59PM +0200, Nicolas George wrote:
> lance.lmwang at gmail.com (12020-06-20):
> > av_timecode_init_from_string() will initialize the AVTimecode structure,
> > it'll do more functions, if don't duplicate the code. I can do like below:
> > 1. use av_timecode_init_from_string() to init the tc
> > 2. use av_timecode_get_smpte_from_framenum() to get the smpte binary
> > 
> > do you think it's OK?
> 
> Yes, I think it is the correct way of doing it: using existing functions
> instead of copying their code.

Thanks, have updated with 2 patch only.

> 
> Regards,
> 
> -- 
>   Nicolas George



> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


-- 
Thanks,
Limin Wang