[FFmpeg-devel] [Patch] vf_edgedetect: properly implement double_threshold()

Moritz Barsnick barsnick at gmx.net
Mon Jun 22 13:53:49 EEST 2020


On Fri, Jun 19, 2020 at 17:15:06 +0200, Valery Kot wrote:
> -            if ((!i || i == w - 1 || !j || j == h - 1) &&
> +            if (!(!i || i == w - 1 || !j || j == h - 1) &&

NOT of a logical OR can be inverted, so this *may* be more readable as:
               if ((i && i != w - 1 && j && j != h - 1) &&
or even drop the bracket
               if (i && i != w - 1 && j && j != h - 1 &&

Untested, just from observation.

Moritz


More information about the ffmpeg-devel mailing list