[FFmpeg-devel] [PATCH v3 2/2] libavformat/img2dec: Added pgx demuxer

[Gautam Ramakrishnan]

On Sun, Jun 28, 2020 at 8:16 PM Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>
> Am So., 28. Juni 2020 um 16:43 Uhr schrieb <gautamramk at gmail.com>:
> >
> > From: Gautam Ramakrishnan <gautamramk at gmail.com>
> >
> > This patch adds support to demux pgx file
> > format.
>
> Has anything changed compared to earlier versions?
No change. I didnt realize that it is exclusive from the first
patch of the series and does not have to be resubmitted.
>
> > ---
> >  libavformat/allformats.c |  1 +
> >  libavformat/img2dec.c    | 10 ++++++++++
> >  libavformat/version.h    |  2 +-
> >  3 files changed, 12 insertions(+), 1 deletion(-)
> >
> > diff --git a/libavformat/allformats.c b/libavformat/allformats.c
> > index 97fd06debb..f8527b1fd4 100644
> > --- a/libavformat/allformats.c
> > +++ b/libavformat/allformats.c
> > @@ -488,6 +488,7 @@ extern AVInputFormat  ff_image_pbm_pipe_demuxer;
> >  extern AVInputFormat  ff_image_pcx_pipe_demuxer;
> >  extern AVInputFormat  ff_image_pgmyuv_pipe_demuxer;
> >  extern AVInputFormat  ff_image_pgm_pipe_demuxer;
> > +extern AVInputFormat  ff_image_pgx_pipe_demuxer;
> >  extern AVInputFormat  ff_image_pictor_pipe_demuxer;
> >  extern AVInputFormat  ff_image_png_pipe_demuxer;
> >  extern AVInputFormat  ff_image_ppm_pipe_demuxer;
> > diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c
> > index ee7ceed08f..ec27e04a30 100644
> > --- a/libavformat/img2dec.c
> > +++ b/libavformat/img2dec.c
> > @@ -1000,6 +1000,15 @@ static int pgmyuv_probe(const AVProbeData *p) // custom FFmpeg format recognized
> >      return ret && av_match_ext(p->filename, "pgmyuv") ? ret : 0;
> >  }
> >
> > +static int pgx_probe(const AVProbeData *p)
> > +{
> > +    const uint8_t *b = p->buf;
> > +    int ret = (AV_RB64(b) & 0xFFFFFFFFFFFF0000) == 0x5047204D4C200000;
> > +    if (ret)
> > +        return AVPROBE_SCORE_EXTENSION + 1;
> > +    return 0;
>
> Why is the variable ret useful?
It is not useful, should I remove it and resubmit?




-- 
-------------
Gautam |