[FFmpeg-devel] [PATCH 4/4] vaapi_encode_h265: Enable 4:2:2 support

[Mark Thompson]

On 05/03/2020 02:49, Fu, Linjie wrote:
> 2. recon surface of Y210 or 444 (AYUV and Y410 in media-driver) depends on the surface hint [3] in
> libva and corresponding code in media-driver to resize the recon surface which is not upstreamed
> yet.

What is the reasoning for forcing the user to pass new extra attributes with this rather than handling it transparently so that it works like all other encoders?

In some places in Mesa surfaces are reallocated with different properties when they are used for a purpose they don't currently support, which avoids weird constraints being exported to the user (e.g. see <https://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/state_trackers/va/surface.c#n1000>).  Since reconstructed picture surfaces are pretty unlikely to be used for anything else (just being copied out for debugging maybe?), it seems like an answer like that would be simpler in this case too.  (Though perhaps I'm missing something weird about the Intel hardware which makes this case uglier.)

- Mark