[FFmpeg-devel] [PATCH 18/18] h264_ps: pass AVCodecContext as void* where possible

[Michael Niedermayer]

On Fri, Mar 13, 2020 at 11:28:50AM +0100, Anton Khirnov wrote:
> Makes sure it is only used for logging and nothing else.
> ---
>  libavcodec/h264_ps.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/libavcodec/h264_ps.c b/libavcodec/h264_ps.c
> index 1951bb1161..4ef25aa514 100644
> --- a/libavcodec/h264_ps.c
> +++ b/libavcodec/h264_ps.c
> @@ -104,14 +104,14 @@ static void remove_sps(H264ParamSets *s, int id)
>      av_buffer_unref(&s->sps_list[id]);
>  }
>  
> -static inline int decode_hrd_parameters(GetBitContext *gb, AVCodecContext *avctx,
> +static inline int decode_hrd_parameters(GetBitContext *gb, void *logctx,

this is a double sided sword
while fields of logctx cannot be used its after this possible to pass
wrong things as logctx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200313/3a692cbe/attachment.sig>