[FFmpeg-devel] [PATCH 01/18] mpeg4videodec: do not copy a range of fields at once

Anton Khirnov anton at khirnov.net
Sun Mar 15 19:03:46 EET 2020


Quoting Carl Eugen Hoyos (2020-03-14 13:42:33)
> Am Sa., 14. März 2020 um 12:58 Uhr schrieb Paul B Mahol <onemda at gmail.com>:
> >
> > On 3/14/20, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> > > Am Fr., 13. März 2020 um 11:30 Uhr schrieb Anton Khirnov
> > > <anton at khirnov.net>:
> > >
> > > Am I really the only one who finds the code more "fragile" after this
> > > change?
> >
> > Elaborate how it is "fragile"?
> 
> Because new fields might be forgotten.

Not all fields are necessarily to be copied. Whether to copy any given
field is a decision that should be done explicitly when it is added.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list