[FFmpeg-devel] [PATCH] avformat/dashdec: Don't allocate and leak strings that are never used

Steven Liu lq at chinaffmpeg.org
Mon Mar 16 15:29:05 EET 2020



> 2020年3月16日 下午9:26,Nicolas George <george at nsup.org> 写道:
> 
> Steven Liu (12020-03-16):
>>> How can they fix a problem if they are unused?
>> As Andreas said, just xmlFree them at the end of the parse method is ok,
>> I think i will use them for full support do that if you guys don’t know how to  do that.
> 
> This commit e134c203 was clearly not fully baked. Let's revert it. And
> if you can contribute a commit that actually does something, with proper
> lifetime for the variables, we can bring it back.
Let me do it now, don’t remove the code, ok?
Keep the code now or add xmlFree them.
> 
> Regards,
> 
> -- 
>  Nicolas George



More information about the ffmpeg-devel mailing list