[FFmpeg-devel] [PATCH][GSOC] avfilter: add atone filter

Anton Khirnov anton at khirnov.net
Mon Mar 16 17:02:29 EET 2020


Quoting Marshall Murmu (2020-03-16 12:19:55)
> On Mon, Mar 16, 2020 at 3:40 PM Moritz Barsnick <barsnick at gmx.net> wrote:
> 
> > Hi Marshall,
> >
> > On Sat, Mar 14, 2020 at 15:58:32 +0530, Marshall Murmu wrote:
> >
> > > +    {"soundfont",   "location of soundfont",
> >  OFFSET(soundfont),   AV_OPT_TYPE_STRING,   {.str=NULL},     CHAR_MIN,
> > CHAR_MAX,  FLAGS},
> >
> > I don't think we define ranges for AV_OPT_TYPE_STRING.
> >
>  I looked at other filters and found that some had defined the ranges as
> (CHAR_MIN, CHAR_MAX) or (0,0)  or the range was not defined. So I didn't
> think it would be an issue.

That is a cargo cult and has no effect whatsoever. Better not set it at
all to avoid propagating this misunderstanding.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list