[FFmpeg-devel] [PATCH 13/18] h264_sei: parse the picture timing SEIs correctly

[Michael Niedermayer]

On Fri, Mar 13, 2020 at 11:28:45AM +0100, Anton Khirnov wrote:
> Those SEIs refer to the currently active SPS. However, since the SEI
> NALUs precede the coded picture data in the bitstream, the active SPS is
> in general not known when we are decoding the SEI.
> 
> Therefore, store the content of the picture timing SEIs and actually
> parse it when the active SPS is known.
> ---
>  libavcodec/h264_parser.c |  9 +++++
>  libavcodec/h264_sei.c    | 86 ++++++++++++++++++++++++----------------
>  libavcodec/h264_sei.h    | 11 +++++
>  libavcodec/h264_slice.c  | 10 +++++
>  4 files changed, 82 insertions(+), 34 deletions(-)

This seems to break fate

TEST    cbs-h264-CVSE2_Sony_B
--- ./tests/ref/fate/cbs-h264-CVSE2_Sony_B	2020-03-15 16:08:13.692521532 +0100
+++ tests/data/fate/cbs-h264-CVSE2_Sony_B	2020-03-16 19:50:23.164302663 +0100
@@ -1 +0,0 @@
-ca8bdba497bd2f3b97c50d59692eb537
Test cbs-h264-CVSE2_Sony_B failed. Look at tests/data/fate/cbs-h264-CVSE2_Sony_B.err for details.
tests/Makefile:250: recipe for target 'fate-cbs-h264-CVSE2_Sony_B' failed
make: *** [fate-cbs-h264-CVSE2_Sony_B] Error 1

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship: All citizens are under surveillance, all their steps and
actions recorded, for the politicians to enforce control.
Democracy: All politicians are under surveillance, all their steps and
actions recorded, for the citizens to enforce control.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200316/04b8c3b7/attachment.sig>