[FFmpeg-devel] [PATCH v3 7/7] avformat/audiointerleave: use a fixed frame duration for non-audio packets

[Tomas Härdin]

lör 2020-03-14 klockan 17:59 +0100 skrev Marton Balint:
> 
> On Sat, 14 Mar 2020, Tomas Härdin wrote:
> 
> > fre 2020-03-13 klockan 02:31 +0100 skrev Marton Balint:
> > > The packet durations might not be set properly which can cause the MXF muxer
> > > to write more than one packet of a stream to an edit unit messing up the
> > > constant byte per element index...
> > 
> > Shouldn't this be fixed "higher up"?
> 
> It should also be fixed higher up, but the MXF muxer should never write 
> broken files, so it should be fixed here as well, either with a warning, 
> and discarding input timestamps/durations or rejecting such attempts 
> completely.
> 
> > > Also warn the user if the incoming DTS is not increasing by frame duration
> > > because in that case A-V sync issues can occur because of the DTS rewriting.
> > 
> > I'm not a huge fan of this, shouldn't we investigate why this happens
> > instead? DTS being non-monotonic is a big deal
> 
> fate-copy-trac4914 is an example of this, it is a stream copy for video.

Ugh. Well, OK then I guess.

/Tomas