[FFmpeg-devel] [PATCH v9 4/4] avcodec/h264: create user data unregistered SEI side data for H.264

[James Almer]

On 3/18/2020 10:29 AM, Anton Khirnov wrote:
> Quoting James Almer (2020-03-17 17:36:01)
>> On 3/17/2020 1:05 PM, Kieran Kunhya wrote:
>>> On Tue, 17 Mar 2020 at 11:25, <lance.lmwang at gmail.com> wrote:
>>>
>>>> From: Limin Wang <lance.lmwang at gmail.com>
>>>>
>>>> Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
>>>>
>>>
>>> I've seen whole planes (e.g Alpha) taking up 10s or 100s of KB put in SEI,
>>> do we really want to export this all as side data?
>>
>> Frame side data is reference counted, so it shouldn't be an issue.
> 
> Since this is unlikely to be useful generically - you have to know
> exactly what's in there - perhaps we should export it only if the caller
> requests it through some AV_CODEC_EXPORT_DATA flag.

Yes, assuming this is approved in general, that's should definitely be done.