[FFmpeg-devel] [PATCH v1] avformat/mxfdec: use av_asprintf()

[Michael Niedermayer]

On Mon, Mar 23, 2020 at 08:29:32PM +0100, Tomas Härdin wrote:
> sön 2020-03-22 klockan 23:03 +0800 skrev lance.lmwang at gmail.com:
> > From: Limin Wang <lance.lmwang at gmail.com>
> > 
> > Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
> > ---
> >  libavformat/mxfdec.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> > 
> > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> > index 9113e2a09c..3374f36a88 100644
> > --- a/libavformat/mxfdec.c
> > +++ b/libavformat/mxfdec.c
> > @@ -2017,7 +2017,7 @@ static MXFStructuralComponent*
> > mxf_resolve_sourceclip(MXFContext *mxf, UID *stro
> >  static int mxf_parse_package_comments(MXFContext *mxf, AVDictionary
> > **pm, MXFPackage *package)
> >  {
> >      MXFTaggedValue *tag;
> > -    int size, i;
> > +    int i;
> >      char *key = NULL;
> >  
> >      for (i = 0; i < package->comment_count; i++) {
> > @@ -2025,12 +2025,10 @@ static int
> > mxf_parse_package_comments(MXFContext *mxf, AVDictionary **pm, MXFPac
> >          if (!tag || !tag->name || !tag->value)
> >              continue;
> >  
> > -        size = strlen(tag->name) + 8 + 1;
> > -        key = av_mallocz(size);
> > +        key = av_asprintf("comment_%s", tag->name);
> >          if (!key)
> >              return AVERROR(ENOMEM);
> >  
> > -        snprintf(key, size, "comment_%s", tag->name);
> >          av_dict_set(pm, key, tag->value, AV_DICT_DONT_STRDUP_KEY);
> >      }
> >      return 0;
> 
> Looks OK

will apply

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

"Nothing to hide" only works if the folks in power share the values of
you and everyone you know entirely and always will -- Tom Scott

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200323/9a3e47b5/attachment.sig>