[FFmpeg-devel] [PATCH v2 3/3] avfilter/af_adelay: Check sscanf() return value

[Michael Niedermayer]

On Sat, Mar 28, 2020 at 08:17:33AM +0800, lance.lmwang at gmail.com wrote:
> From: Limin Wang <lance.lmwang at gmail.com>
> 
> Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
> ---
>  libavfilter/af_adelay.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/libavfilter/af_adelay.c b/libavfilter/af_adelay.c
> index c964777..2bb05e7 100644
> --- a/libavfilter/af_adelay.c
> +++ b/libavfilter/af_adelay.c
> @@ -155,7 +155,10 @@ static int config_input(AVFilterLink *inlink)
>          ret = av_sscanf(arg, "%d%c", &d->delay, &type);
>          if (ret != 2 || type != 'S') {
>              div = type == 's' ? 1.0 : 1000.0;
> -            av_sscanf(arg, "%f", &delay);
> +            if (av_sscanf(arg, "%f", &delay) != 1) {

> +                av_log(ctx, AV_LOG_ERROR, "Invalid syntax.\n");

I suggest to print the part of the string that is invalid.
This would make it easier to the user to know where the error is

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200328/ad43377c/attachment.sig>