[FFmpeg-devel] [PATCH] [libavutil] Add saturated add/sub operations for int64_t.

[Carl Eugen Hoyos]

Am Fr., 1. Mai 2020 um 19:41 Uhr schrieb Dale Curtis <dalecurtis at chromium.org>:
>
> On Fri, May 1, 2020 at 10:32 AM James Almer <jamrial at gmail.com> wrote:
>
> > On 5/1/2020 2:23 PM, Dale Curtis wrote:
> > > On Fri, May 1, 2020 at 6:12 AM James Almer <jamrial at gmail.com> wrote:
> > >
> > >> On 5/1/2020 6:36 AM, Carl Eugen Hoyos wrote:
> > >>>
> > >>> The macro exists to avoid separate patches?
> > >>
> > >> No, it exists to not require configure checks just to enable a path for
> > >> gcc/clang and another for other compilers.
> > >>
> > >
> > > Since consensus seems to have landed on splitting the patches, I've done
> > > so. This thread now contains just the default implementation.
> >
> > That wasn't the consensus. Neither Nicholas or I thought it was
> > required, but i don't have strong feelings about it.
> >
>
> Ah sorry for misunderstanding, your response to Carl above only seemed to
> refute the necessity of a configure patch. I also don't care either way.
>
>
> > > +static int64_t av_sat_add64_c(int64_t a, int64_t b) {
> >
> > Missing av_always_inline attribute
> >
>
> Done.
>
>
> >
> > > +static int64_t av_sat_sub64_c(int64_t a, int64_t b) {
> >
> > Ditto
> >
>
> Done.

Could you confirm that you attached the wrong patch?

Or is it just my system?

Sorry, Carl Eugen