[FFmpeg-devel] [PATCH] avformat/matroskaenc: always reserve max aac private data

Nicolas George george at nsup.org
Fri May 1 21:10:07 EEST 2020


John Stebbins (12020-05-01):
> If the parameters change on the fly, some part of the audio stream is
> going to be unplayable.  Either the part after the change will be
> unplayable if you ignore extradata changes, or everything preceeding 
> the last extradata change will be unplayable if you rewrite codec
> private on every change.

Then the only acceptable solution is to report an error.

If we can detect that the new extradata is compatible and will not cause
the file to be unplayable, we can let it pass, but we should try to
NEVER allow to lose data without notifying users.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200501/ed5459cb/attachment.sig>


More information about the ffmpeg-devel mailing list