[FFmpeg-devel] [PATCH] avformat/matroskaenc: always reserve max aac private data

[Nicolas George]

Andreas Rheinhardt (12020-05-01):
> I'd rather opt to only warn in such a case unless strict_std_compliance
> is >= FF_COMPLIANCE_STRICT. And maybe we should also discard all future
> packets from this stream until we get one with side data matching the
> CodecPrivate one?

It is not a matter of standard compliance, it is a matter of lost data.
If only one extradata is written, then the other is discarded, and
possibly all subsequent packets are un-decodable.

Without an AVERROR code up the stack, a GUI application (most of them
just let av_log go to stderr) could open a dialog "Data successfully
saved. Delete original? [Yes] No" and let actual data be lost.

We can have an option to ignore the error, but as it is, it really must
be an error condition by default. Exactly the same as a write error on
the file.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200501/a0e5a3ea/attachment.sig>