[FFmpeg-devel] [PATCH 2/4] doc/examples/muxing.c: Fixed a compile warning

[Zhao, Gang]

On Sat, May 2, 2020 at 6:13 PM Nicolas George <george at nsup.org> wrote:

> Zhao, Gang (12020-05-02):
> > Fixed deprecation declarations compile warning by replacing deprecated
> > api avcodec_encode_{audio,video}2() with
> > avcodec_send_frame()/avcodec_receive_packet(). Also made some clean up
> > according to this change.
>
> That is not "fixing a warning", that is changing the whole logic. At the
> very least, th commit message should say that.
>
> I suggested a new commit log in reply to your comment in patch 01.


> But your changes seemed a little more invasive than that, for example
> renaming functions.


With the new api, function write_audio_frame and write_video_frame can be
combined to one.
Because there is already a local function called write_frame, I changed the
name to muxing_write_frame
to avoid name collision.

>
>
Regards,
>
> --
>   Nicolas George
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".