[FFmpeg-devel] [PATCH v4 1/2] libavcodec/libaomenc.c: Support gray input

[Ryo Hirafuji]

Hi.

https://crbug.com/aomedia/2545

This bug is resolved and we no longer need these lines to avoid crash in
libaom.

> -        rawimg->planes[AOM_PLANE_U] = frame->data[1];
> -        rawimg->planes[AOM_PLANE_V] = frame->data[2];
> -        rawimg->stride[AOM_PLANE_U] = frame->linesize[1];
> -        rawimg->stride[AOM_PLANE_V] = frame->linesize[2];

I can create and send a new patch without these workaround lines, but of
course, it will crash if the ffmpeg will be built with older versions of
libaom.
How should I resolve this backward compatibility issue? or I don't have to
consider it?

Please give me some advice.


2020年4月16日(木) 2:58 James Zern <jzern-at-google.com at ffmpeg.org>:

> On Wed, Apr 15, 2020 at 8:14 AM James Almer <jamrial at gmail.com> wrote:
> >
> > On 4/14/2020 9:26 PM, James Zern wrote:
> > > On Tue, Apr 14, 2020 at 3:57 AM Ryo Hirafuji <
> ryo.hirafuji at link-u.co.jp> wrote:
> > >>
> > >> Thanks for the review!
> > >>
> > >> This should bump the micro version number in libavcodec/version.h.
> > >>
> > >>
> > >> OK, I will bump up the version when the problem below is solved.
> > >>
> > >
> > > If we want to go for compatibility with different versions of the
> > > library we could move forward with the patch as is, though it would be
> > > simpler to just treat this as a bug fix in libaom.
> >
> > Once a new version of libaom is tagged (Hopefully soon, since it's been
> > almost two years since 1.0.0), we could set it as the minimum
> > requirement and forget about 1.0.0, since that version is by now
> > essentially unusable.
> >
>
> Thanks, that was my hope. I just wasn't sure how long we wanted to
> wait before changing the minimum. You're right though, the only tags
> are old and were more for bitstream compatibility rather than encoder
> functionality. A full release should be coming soon [1] and with more
> regular frequency after that.
>
> [1] https://crbug.com/aomedia/2545
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".