[FFmpeg-devel] [PATCH] avformat/mux: Check pkt->stream_index before using it

[Anton Khirnov]

Quoting Andreas Rheinhardt (2020-05-08 00:55:00)
> This commit fixes two recent regressions both of which are about using
> pkt->stream_index as index in an AVFormatContext's streams array before
> actually comparing the value with the count of streams in said array.
> 96e5e6abb9851d7a26ba21703955d5826ac857c0 did this in
> prepare_input_packet() and 64063512227c4c87a7d16a1076481dc6baf19841 did
> likewise in write_packets_common().
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> ---
> The same error in the same file applied on the same day by two different
> people. How unlikely.

How is it a regression? Isn't it rather invalid API use?

Not that I object to having a check. But then why is check_packet()
called so deep and not immediately on entry to the muxer?

-- 
Anton Khirnov