[FFmpeg-devel] [PATCH] pixblockdsp, avdct: Add get_pixels_unaligned

Michael Niedermayer michael at niedermayer.cc
Tue May 12 21:54:58 EEST 2020


On Tue, May 12, 2020 at 11:25:34AM +0300, Martin Storsjö wrote:
> Use this in vf_spp.c, where the get_pixels operation is done on
> unaligned source addresses.
> 
> This fixes fate-filter-spp on armv7.

LGTM


> ---
> People more familiar with the other assembly implementations of
> get_pixels (in particular, x86) can hook them up to
> get_pixels_unaligned if unaligned use explicitly is ok; as far as I
> can read at least ff_get_pixels_mmx, it looks like it expects the source
> to be aligned, but in practice it does seem to run fine even if
> ff_get_pixels_sse2 is disabled.
> ---

id suggest that code that has been tested with unaligned data and works
is enabled

thx


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct answer.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200512/f985e941/attachment.sig>


More information about the ffmpeg-devel mailing list