[FFmpeg-devel] [PATCH v5 1/4] avcodec/adpcmenc: add capabilities argument to ADPCM_ENCODER()

[Paul B Mahol]

Why sending this kind of patches?

I see no point in this patch?

On 5/16/20, Zane van Iperen <zane at zanevaniperen.com> wrote:
> Signed-off-by: Zane van Iperen <zane at zanevaniperen.com>
> ---
>  libavcodec/adpcmenc.c | 33 +++++++++++++++++----------------
>  1 file changed, 17 insertions(+), 16 deletions(-)
>
> diff --git a/libavcodec/adpcmenc.c b/libavcodec/adpcmenc.c
> index 668939c778..d3098a8f9c 100644
> --- a/libavcodec/adpcmenc.c
> +++ b/libavcodec/adpcmenc.c
> @@ -706,21 +706,22 @@ static const enum AVSampleFormat sample_fmts_p[] = {
>      AV_SAMPLE_FMT_S16P, AV_SAMPLE_FMT_NONE
>  };
>
> -#define ADPCM_ENCODER(id_, name_, sample_fmts_, long_name_) \
> -AVCodec ff_ ## name_ ## _encoder = {                        \
> -    .name           = #name_,                               \
> -    .long_name      = NULL_IF_CONFIG_SMALL(long_name_),     \
> -    .type           = AVMEDIA_TYPE_AUDIO,                   \
> -    .id             = id_,                                  \
> -    .priv_data_size = sizeof(ADPCMEncodeContext),           \
> -    .init           = adpcm_encode_init,                    \
> -    .encode2        = adpcm_encode_frame,                   \
> -    .close          = adpcm_encode_close,                   \
> -    .sample_fmts    = sample_fmts_,                         \
> +#define ADPCM_ENCODER(id_, name_, sample_fmts_, capabilities_, long_name_)
> \
> +AVCodec ff_ ## name_ ## _encoder = {
> \
> +    .name           = #name_,
> \
> +    .long_name      = NULL_IF_CONFIG_SMALL(long_name_),
> \
> +    .type           = AVMEDIA_TYPE_AUDIO,
> \
> +    .id             = id_,
> \
> +    .priv_data_size = sizeof(ADPCMEncodeContext),
> \
> +    .init           = adpcm_encode_init,
> \
> +    .encode2        = adpcm_encode_frame,
> \
> +    .close          = adpcm_encode_close,
> \
> +    .sample_fmts    = sample_fmts_,
> \
> +    .capabilities   = capabilities_,
> \
>  }
>
> -ADPCM_ENCODER(AV_CODEC_ID_ADPCM_IMA_QT,  adpcm_ima_qt,  sample_fmts_p,
> "ADPCM IMA QuickTime");
> -ADPCM_ENCODER(AV_CODEC_ID_ADPCM_IMA_WAV, adpcm_ima_wav, sample_fmts_p,
> "ADPCM IMA WAV");
> -ADPCM_ENCODER(AV_CODEC_ID_ADPCM_MS,      adpcm_ms,      sample_fmts,
> "ADPCM Microsoft");
> -ADPCM_ENCODER(AV_CODEC_ID_ADPCM_SWF,     adpcm_swf,     sample_fmts,
> "ADPCM Shockwave Flash");
> -ADPCM_ENCODER(AV_CODEC_ID_ADPCM_YAMAHA,  adpcm_yamaha,  sample_fmts,
> "ADPCM Yamaha");
> +ADPCM_ENCODER(AV_CODEC_ID_ADPCM_IMA_QT,  adpcm_ima_qt,  sample_fmts_p, 0,
> "ADPCM IMA QuickTime");
> +ADPCM_ENCODER(AV_CODEC_ID_ADPCM_IMA_WAV, adpcm_ima_wav, sample_fmts_p, 0,
> "ADPCM IMA WAV");
> +ADPCM_ENCODER(AV_CODEC_ID_ADPCM_MS,      adpcm_ms,      sample_fmts,   0,
> "ADPCM Microsoft");
> +ADPCM_ENCODER(AV_CODEC_ID_ADPCM_SWF,     adpcm_swf,     sample_fmts,   0,
> "ADPCM Shockwave Flash");
> +ADPCM_ENCODER(AV_CODEC_ID_ADPCM_YAMAHA,  adpcm_yamaha,  sample_fmts,   0,
> "ADPCM Yamaha");
> --
> 2.25.1
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".