[FFmpeg-devel] [PATCH 2/2] fate: add tests for h264 and vp9 video enc parameters export

[James Almer]

On 5/19/2020 11:12 AM, Michael Niedermayer wrote:
> On Mon, May 18, 2020 at 11:45:21AM +0200, Anton Khirnov wrote:
>> ---
>>  libavformat/Makefile          |   1 +
>>  tests/Makefile                |   1 +
>>  tests/fate-run.sh             |   7 +
>>  tests/fate/h264.mak           |   6 +-
>>  tests/fate/vpx.mak            |   5 +
>>  tests/ref/fate/h264-encparams | 404 +++++++++++++++
>>  tests/ref/fate/vp9-encparams  | 937 ++++++++++++++++++++++++++++++++++
>>  tools/venc_data_dump.c        | 195 +++++++
>>  8 files changed, 1555 insertions(+), 1 deletion(-)
>>  create mode 100644 tests/ref/fate/h264-encparams
>>  create mode 100644 tests/ref/fate/vp9-encparams
>>  create mode 100644 tools/venc_data_dump.c
> 
> These tests fail on mingw32
> 
> --- src/tests/ref/fate/vp9-encparams	2020-05-19 16:09:39.771297305 +0200
> +++ tests/data/fate/vp9-encparams	2020-05-19 16:10:18.091233040 +0200
> @@ -1,937 +0,0 @@
> -frame 0
> -AVVideoEncParams 0
> -qp 65
> -nb_blocks 731
> -block 0 0:0 64x64 33
> -block 1 64:0 16x16 -12
> -block 2 80:0 16x16 -12
> -block 3 64:16 16x8 0
> -block 4 64:24 16x8 0
> -block 5 80:16 8x16 0
> -block 6 88:16 8x16 0
> -block 7 96:0 32x16 -23
> -block 8 96:16 32x16 0
> ...
> src/tests/fate-run.sh: 494: eval: tools/venc_data_dump.exe: Exec format error
> src/tests/Makefile:255: recipe for target 'fate-vp9-encparams' failed

This is under wine, right? venc_data() may need to call the executable
using run(), which appends $target_exec to the command line.