[FFmpeg-devel] [PATCH v3 2/2] avdevice/lavf: change the dumpgraph option to bool type

[Nicolas George]

Nicolas George (12020-05-19):
> Originally, the second parameter to avfilter_graph_dump() was supposed
> to be dump options. None was ever added, and I later came to realize
> that using a string for that was more of the same bad idea.
> 
> I have no objection to making this bit obsolete, but please do it
> knowingly.

Again, forgot something before sending:

The idea was to be able to output other kinds of graph representation.
The current one is a very clumsy attempt at ASCII-art. But we could have
added:

	avfilter_graph_dump(graph, "fmt=dot");

to get output in Graphviz DOT format, basically importing
tools/graph2dot.c into libavfilter/graphdump.c. Finally doing that may
be a better idea than obsoleting the option.

And of course, other formats are possible too.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200519/d131f32a/attachment.sig>