[FFmpeg-devel] [PATCH v2] avcodec: Add MediaFoundation encoder wrapper

[Martin Storsjö]

On Mon, 18 May 2020, Aman Gupta wrote:

> On Fri, May 15, 2020 at 12:04 AM Martin Storsjö <martin at martin.st> wrote:
>
>> On Tue, 12 May 2020, Martin Storsjö wrote:
>>
>> > From: wm4 <nfxjfg at googlemail.com>
>> >
>> > This contains encoder wrappers for H264, HEVC, AAC, AC3 and MP3.
>> >
>> > This is based on top of an original patch by wm4
>> > <nfxjfg at googlemail.com>. The original patch supported both encoding
>> > and decoding, but this patch only includes encoding.
>> >
>> > The patch contains further changes by Paweł Wegner
>> > <pawel.wegner95 at gmail.com> (primarily for splitting out the encoding
>> > parts of the original patch) and further cleanup, build compatibility
>> > fixes and tweaks for use with Qualcomm encoders by Martin Storsjö.
>> > ---
>> > v2: Added AV_CODEC_CAP_HYBRID, removed a leftover unused AVBSFContext,
>> > added changelog and encoders.text entries, renamed the configure option
>> > and config item to "mediafoundation" instead of "mf", changed the
>> > makefile to keep individual additions of object files for each
>> > individual encoder (so that it isn't compiled if all encoders are
>> > disabled, even if CONFIG_MEDIAFOUNDATION is enabled).
>>
>> Any further comments on this, or is it ok to be merged now?
>
>
> +1 from me. We have been using the original patchset for quite a few years
> now, and it will make things much easier if it is included upstream.
>
> For encoding video, we found the mf apis work much more reliably across
> different hardware (and versions of Windows) compared to using qsv directly.

Thanks - pushed this now!

// Martin