[FFmpeg-devel] [PATCH] avcodec/libx265: add support for reordered_opaque

[James Almer]

On 5/19/2020 5:18 PM, Derek Buitenhuis wrote:
> On 19/05/2020 19:55, James Almer wrote:
>> +        if (pic->reordered_opaque) {
> 
> If this is meant to be PTS, won't this break on PTS==0?
> 
> - Derek

When pic->reordered_opaque is 0 (default value) x265pic.userData will
remain NULL. This in turn means x265pic_out.userData will also be NULL
and avctx->reordered_opaque will be set to 0, so it's functionally the
expected behavior.
This is done to avoid a malloc() per frame in 99% of use cases where
reordered_opaque is not going to be used.