[FFmpeg-devel] [PATCH 2/2] hwcontext_vulkan: expose the enabled device features

Lynne dev at lynne.ee
Thu May 21 01:25:50 EEST 2020


May 20, 2020, 22:56 by sw at jkqxz.net:

> On 19/05/2020 21:56, Lynne wrote:
>
> "Each pNext member of any structure (including this one) in the pNext chain must be either NULL or a pointer to a valid instance of ... [big list which does not include VkPhysicalDeviceFeatures]."  Was that meant to be VkPhysicalDeviceFeatures2?
>

Yes, I fixed that after haasn pointed it out.
Here's the new patch just in case with that fixed and the new description.
Removed the "that is, it should be a copy of the pEnabledFeatures field passed in..." since
when VkDeviceCreateInfo.pNext is VkPhysicalDeviceFeatures2 the pEnabledFeatures field
must not be set.

>     * This structure should be set to the set of features that present and enabled 
>     * during device creation. hen a device is created by FFmpeg, it will default to
>     * enabling all that are present of the shaderImageGatherExtended,
>     * fragmentStoresAndAtomics, shaderInt64 and vertexPipelineStoresAndAtomics features.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-hwcontext_vulkan-expose-the-enabled-device-features.patch
Type: text/x-patch
Size: 3240 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200521/e699830c/attachment.bin>


More information about the ffmpeg-devel mailing list